LSP Optimization: Use rayon for parse_ast_to_typed_tokens function
#5473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
auto-merge was automatically disabled
January 16, 2024 02:47
Pull request was converted to draft
|
How come collecting typed tokens is taking |
This is how long it's taking to traverse and collect the tokens from the typed AST nodes. I'm going to look at using rayon par_iters for this section like we are doing in the Edit, i've managed to get it down to |
crodas
reviewed
Jan 17, 2024
JoshuaBatty
force-pushed
the
josh/parse_ast_to_typed_tokens_rayon
branch
from
40bab43
to
67f3c6e
Compare
7 tasks
tritao
approved these changes
Jan 17, 2024
crodas
approved these changes
Jan 17, 2024
JoshuaBatty
added a commit
that referenced
this pull request
Jan 17, 2024
…5487) ## Description Use `rayon` par_iters in the `traverse::typed_tree` module. We are already doing this in `traverse::parsed_tree`, this just brings this over to the typed_tree module as well. Branched off #5473. <s>Will want to merge that first then will take this out of draft.</s> Collecting typed tokens on the benchmark project goes from `120.508917ms` → `14.853125ms` related to #5445
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Traversing the typed tokens from
sway-lib-stdnow goes from3.957833ms→1.372ms. Collecting typed tokens on the benchmark project goes from139.6ms→127.7ms.I noticed that there are transient contentions when reading items from the
TokenMapwith this change. As such, I've implemented a new function on theTokenMapcalledtry_get_mut_with_retry. This method tries to access the value up to 8 times if the lock is still held using the backoff and retry pattern.related to #5445
Checklist
Breaking*orNew Featurelabels where relevant.